[
https://issues.apache.org/jira/browse/YARN-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877018#comment-16877018
]
Sunil Govindan commented on YARN-9629:
--------------------------------------
Thanks [~adam.antal]
First point makes sense if the default value is -1 and this code will always
kick in if this is never configured
For #2, given a configuration is done, its always better to cleanly say like in
that last else condition, Hence taking it out and show same log in both kind of
scenario still makes sense to me. in first log, you can minimize content if its
duplicated, however skipping else conditions looks more cleaner and generic.
> Support configurable MIN_LOG_ROLLING_INTERVAL
> ---------------------------------------------
>
> Key: YARN-9629
> URL: https://issues.apache.org/jira/browse/YARN-9629
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: log-aggregation, nodemanager, yarn
> Affects Versions: 3.2.0
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Minor
> Attachments: YARN-9629.001.patch, YARN-9629.002.patch,
> YARN-9629.003.patch, YARN-9629.004.patch, YARN-9629.005.patch
>
>
> One of the log-aggregation parameter, the minimum valid value for
> {{yarn.nodemanager.log-aggregation.roll-monitoring-interval-seconds}} is
> MIN_LOG_ROLLING_INTERVAL - it has been hardcoded since its addition in
> YARN-2583.
> It has been empirically set as 1 hour, as lower values would too frequently
> put the NodeManagers under pressure. For bigger clusters that is indeed a
> valid limitation, but for smaller clusters it makes sense and a valid
> customer usecase to use lower values, even like not so lower 30 mins. At this
> point this can only be achieved by setting
> {{yarn.nodemanager.log-aggregation.debug-enabled}}, which I believe should be
> kept as debug purposes.
> I'm suggesting to make this min configurable, although a warning should be
> logged in the NodeManager startup when this value is lower than 1 hour.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
