[
https://issues.apache.org/jira/browse/YARN-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883282#comment-16883282
]
Szilard Nemeth commented on YARN-9140:
--------------------------------------
[~pbacsko] Indeed, you are right.
Here's the
[link|https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-YARN-Build/24366/console]
to the build, the overall result was -1, but somehow the comment is not posted
here.
You can check the results in the console log of jenkins.
Retriggered the build, hopefully we will have the results here as well.
> Code cleanup in ResourcePluginManager.initialize and in
> TestResourcePluginManager
> ---------------------------------------------------------------------------------
>
> Key: YARN-9140
> URL: https://issues.apache.org/jira/browse/YARN-9140
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Peter Bacsko
> Priority: Trivial
> Attachments: YARN-9140.001.patch, YARN-9140.002.patch,
> YARN-9140.003.patch, YARN-9140.004.patch
>
>
> Some code cleanup is needed in ResourcePluginManager#initialize:
> * There's a big code block that initializes resource plugins, this should be
> extracted to a separate method.
> * Exception handling could be simplified.
> TestResourcePluginManager minor cleanup:
> * Not thrown exceptions could be deleted from method signatures
> * verify(obj, times(1)).<method>() calls: times(1) parameter could be
> deleted as it is the default if verify(obj) is invoked without the times
> parameter.
> * Some code exceeds the 80 character column limit.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
