[ 
https://issues.apache.org/jira/browse/YARN-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895572#comment-16895572
 ] 

Íñigo Goiri commented on YARN-9694:
-----------------------------------

Thanks [~abmodi] for the patch, a few comments:
* Can you add a javadoc explaining {{testGenerateNodeTableMapping()}}?
* Why do you delete the file first in {{testGenerateNodeTableMapping()}}?
* Can you explain a littl ebetter what's happening in 
{{generateNodeTableMapping()}}? The whole format "node rack" should be referred 
somewhere.
* It doesn't look like csv format for tableMapping.csv.

> UI always show default-rack for all the nodes while running SLS.
> ----------------------------------------------------------------
>
>                 Key: YARN-9694
>                 URL: https://issues.apache.org/jira/browse/YARN-9694
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Abhishek Modi
>            Assignee: Abhishek Modi
>            Priority: Major
>         Attachments: YARN-9694.001.patch, YARN-9694.002.patch
>
>
> Currently, independent of the specification of the nodes in SLS.json or 
> nodes.json, UI always shows that rack of the node is default-rack.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to