[ https://issues.apache.org/jira/browse/YARN-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898799#comment-16898799 ]
Szilard Nemeth commented on YARN-9124: -------------------------------------- Hi [~adam.antal]! Committed to trunk! Please provide patches here for branch-3.2 and branch-3.1. Thanks! > Resolve contradiction in ResourceUtils: addMandatoryResources / > checkMandatoryResources work differently > -------------------------------------------------------------------------------------------------------- > > Key: YARN-9124 > URL: https://issues.apache.org/jira/browse/YARN-9124 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Szilard Nemeth > Assignee: Adam Antal > Priority: Minor > > {{ResourceUtils#addMandatoryResources}}: Adds only memory and vcores as > mandatory resources. > {{ResourceUtils#checkMandatoryResources}}: YARN-6620 added some code to this. > This method not only checks memory and vcores, but all the resources referred > in ResourceInformation#MANDATORY_RESOURCES. > I think it would be good to call {{MANDATORY_RESOURCES}} as > {{PREDEFINED_RESOURCES}} or something like that and use a similar name for > {{checkMandatoryResources}}. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org