[ 
https://issues.apache.org/jira/browse/YARN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803340#comment-13803340
 ] 

Mayank Bansal commented on YARN-956:
------------------------------------

Thanks [~vinodkv] for the review.

Earlier I had the same discussion with [~zjshen] offline and I pointed the same 
point for static variables. Zhijie convinced me for static saying that we 
should only have one store per system. I think there is a point to that because 
if somebody just wants to use the memory store for some reason for AHS then it 
would be very hard for us to support. Else we have to tell them memory store is 
just for testing and if they want to use something like that then they have to 
write their own store.

Thanks,
Mayank

> [YARN-321] Add a testable in-memory HistoryStorage 
> ---------------------------------------------------
>
>                 Key: YARN-956
>                 URL: https://issues.apache.org/jira/browse/YARN-956
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Zhijie Shen
>             Fix For: YARN-321
>
>         Attachments: YARN-956-1.patch, YARN-956-2.patch, YARN-956-3.patch, 
> YARN-956.4.patch, YARN-956.5.patch, YARN-956.6.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to