[
https://issues.apache.org/jira/browse/YARN-9676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906018#comment-16906018
]
Peter Bacsko commented on YARN-9676:
------------------------------------
+1 LGTM (non-binding)
> Add DEBUG and TRACE level messages to AppLogAggregatorImpl and connected
> classes
> --------------------------------------------------------------------------------
>
> Key: YARN-9676
> URL: https://issues.apache.org/jira/browse/YARN-9676
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
>
> During the development of the last items of YARN-6875, it was typically
> difficult to extract information about the internal state of some log
> aggregation related classes (e.g. {{AppLogAggregatiorImpl}} and
> {{LogAggregationFileController}}).
> On my fork I added a few more messages to those classes like:
> - displaying the number of log aggregation cycles
> - displaying the names of the files currently considered for log aggregation
> by containers
> - immediately displaying any exception caught (and sent to the RM in the
> diagnostic messages) during the log aggregation process.
> Those messages were quite useful for debugging if any issue occurs, but
> otherwise it flooded the NM log file with these messages that are usually not
> needed. I suggest to add (some of) these messages in DEBUG or TRACE level.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
