[
https://issues.apache.org/jira/browse/YARN-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803642#comment-13803642
]
Tsuyoshi OZAWA commented on YARN-1335:
--------------------------------------
Thank you for taking this JIRA, Sandy. The new class structure looks good to
me. These are my review comments:
FSSchedulerApp#getAllowedLocalityLevel() should check isStopped flag and return
null when isStopped is true.
Comment about FiCaSchedulerApp is same to SchedulerApplication. Why don't we
deleting FiCaSchedulerApp's comment or correct it? If we correct it, comment
about FSSchedulerApp should also be added.
{code}
+
+ public abstract NodeId getNodeID();
+
{code}
It's better to describe the difference between what SchedulerNode#getNodeID()
returns and what SchedulerNode#getNodeName() returns in javadoc of the method.
> Move duplicate code from FSSchedulerApp and FiCaSchedulerApp into
> SchedulerApplication
> --------------------------------------------------------------------------------------
>
> Key: YARN-1335
> URL: https://issues.apache.org/jira/browse/YARN-1335
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
> Affects Versions: 2.2.0
> Reporter: Sandy Ryza
> Assignee: Sandy Ryza
> Attachments: YARN-1335.patch
>
>
> FSSchedulerApp and FiCaSchedulerApp use duplicate code in a lot of places.
> They both extend SchedulerApplication. We can move a lot of this duplicate
> code into SchedulerApplication.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
