[ https://issues.apache.org/jira/browse/YARN-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908198#comment-16908198 ]
Szilard Nemeth commented on YARN-9679: -------------------------------------- Hi [~adam.antal]! As told on github, I merged your patch to trunk. Could you please provide branch-3.2 / branch-3.1 patches as well? I tried to cherry-pick the trunk patch to 3.2 but it had many conflicts. Thanks! > Regular code cleanup in TestResourcePluginManager > ------------------------------------------------- > > Key: YARN-9679 > URL: https://issues.apache.org/jira/browse/YARN-9679 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Szilard Nemeth > Assignee: Adam Antal > Priority: Major > Labels: newbie > Fix For: 3.3.0 > > > There are several things could be cleaned up in this class: > 1. stubResourcePluginmanager should be private. > 2. In tearDown, the result of dest.delete() should be checked > 3. In class CustomizedResourceHandler, there are several methods where > exceptions decalarations are unnecessary. > 4. Class MyMockNM should be renamed to some more meaningful name. > 5. There are some danling javadoc comments, for example: > {code:java} > /* > * Make sure ResourcePluginManager is initialized during NM start up. > */ > {code} > 6. There are some exceptions unnecessarily declared on test methods but they > are never thrown, an example: > testLinuxContainerExecutorWithResourcePluginsEnabled > 7. Assert.assertTrue(false); expressions should be replaced with Assert.fail() > 8. A handful of usages of Mockito's spy method. This method is not preferred > so we should think about replacing it with mocks, somehow. > The rest can be figured out by whoever takes this jira :) -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org