[ https://issues.apache.org/jira/browse/YARN-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908222#comment-16908222 ]
Adam Antal commented on YARN-9749: ---------------------------------- Sooo my patch actually introduced a bug in the code. When diagnosticMessage.isEmpty() is called (introduced by YARN-9676) it turns out that the message is null. By default it has been set to "" (empty String), thus I didn't recognise it can be an issue. The following line causes the NPE: {noformat} } catch (Exception e) { diagnosticMessage = e.getMessage(); ... } {noformat} We cannot assume that an exception has always proper message text. I'll upload a fix soon. > TestAppLogAggregatorImpl#testDFSQuotaExceeded fails on trunk > ------------------------------------------------------------ > > Key: YARN-9749 > URL: https://issues.apache.org/jira/browse/YARN-9749 > Project: Hadoop YARN > Issue Type: Bug > Components: log-aggregation, test > Reporter: Peter Bacsko > Assignee: Adam Antal > Priority: Major > > TestAppLogAggregatorImpl#testDFSQuotaExceeded currently fails on trunk. It > was most likely introduced by YARN-9676 (resetting HEAD to the previous > commit and then re-running the test passes). > {noformat} > [INFO] Running > org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestAppLogAggregatorImpl > [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.781 > s <<< FAILURE! - in > org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestAppLogAggregatorImpl > [ERROR] > testDFSQuotaExceeded(org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestAppLogAggregatorImpl) > Time elapsed: 2.361 s <<< FAILURE! > java.lang.AssertionError: The set of paths for deletion are not the same as > expected: actual size: 0 vs expected size: 1 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestAppLogAggregatorImpl.verifyFilesToDelete(TestAppLogAggregatorImpl.java:344) > at > org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestAppLogAggregatorImpl.access$000(TestAppLogAggregatorImpl.java:82) > at > org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestAppLogAggregatorImpl$1.answer(TestAppLogAggregatorImpl.java:330) > at > org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestAppLogAggregatorImpl$1.answer(TestAppLogAggregatorImpl.java:319) > at > org.mockito.internal.stubbing.StubbedInvocationMatcher.answer(StubbedInvocationMatcher.java:39) > at > org.mockito.internal.handler.MockHandlerImpl.handle(MockHandlerImpl.java:96) > at > org.mockito.internal.handler.NullResultGuardian.handle(NullResultGuardian.java:29) > at > org.mockito.internal.handler.InvocationNotifierHandler.handle(InvocationNotifierHandler.java:35) > at > org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:61) > at > org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:49) > at > org.mockito.internal.creation.bytebuddy.MockMethodInterceptor$DispatcherDefaultingToRealMethod.interceptSuperCallable(MockMethodInterceptor.java:108) > at > org.apache.hadoop.yarn.server.nodemanager.DeletionService$MockitoMock$1879282050.delete(Unknown > Source) > at > org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.AppLogAggregatorImpl.doAppLogAggregationPostCleanUp(AppLogAggregatorImpl.java:556) > at > org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.AppLogAggregatorImpl.run(AppLogAggregatorImpl.java:476) > at > org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestAppLogAggregatorImpl.testDFSQuotaExceeded(TestAppLogAggregatorImpl.java:469) > ... > {noformat} -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org