[
https://issues.apache.org/jira/browse/YARN-9785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918357#comment-16918357
]
Wangda Tan commented on YARN-9785:
----------------------------------
Thanks [~BilwaST] for the patch and everybody for discussing.
I'm doubt if this is a right fix or not:
{code:java}
public static boolean lessThanOrEqual(
ResourceCalculator resourceCalculator,
Resource clusterResource,
Resource lhs, Resource rhs) {
return resourceCalculator.fitsIn(lhs, rhs)
&& resourceCalculator.compare(clusterResource, lhs, rhs) <= 0;
} {code}
If lhs fits in rhs, the check after && is not need correct? And when we check
less than or equal, we check dominante value of the two resources, I don't
understand why we check fitsIn here.
> Fix DominantResourceCalculator when one resource is zero
> --------------------------------------------------------
>
> Key: YARN-9785
> URL: https://issues.apache.org/jira/browse/YARN-9785
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Bilwa S T
> Assignee: Bilwa S T
> Priority: Blocker
> Attachments: YARN-9785-001.patch, YARN-9785.wip.patch
>
>
> Configure below property in resource-types.xml
> {quote}<property>
> <name>yarn.resource-types</name>
> <value>yarn.io/gpu</value>
> </property>
> {quote}
> Submit applications even after AM limit for a queue is reached. Applications
> get activated even after limit is reached
> !queue.png!
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
