[ https://issues.apache.org/jira/browse/YARN-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919846#comment-16919846 ]
Eric Payne commented on YARN-9773: ---------------------------------- Thanks for the patch, [~maniraj...@gmail.com]! I've taken a first pass at reviewing patch 001. One thing I noticed is that the Available extended resource seems to be inaccurate. I think the problem is in {{QueueMetrics#setAvailableResourcesToQueue}}: Patch 001 says the following: {code} registerCustomResources( queueMetricsForCustomResources.getPendingValues(), AVAILABLE_RESOURCE_METRIC_PREFIX, AVAILABLE_RESOURCE_METRIC_DESC); {code} I think it should be the following: {code} registerCustomResources( queueMetricsForCustomResources.getAvailableValues(), AVAILABLE_RESOURCE_METRIC_PREFIX, AVAILABLE_RESOURCE_METRIC_DESC); {code} > Add QueueMetrics for Custom Resources > ------------------------------------- > > Key: YARN-9773 > URL: https://issues.apache.org/jira/browse/YARN-9773 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Manikandan R > Assignee: Manikandan R > Priority: Major > Attachments: YARN-9773.001.patch > > > Although the custom resource metrics are calculated and saved as a > QueueMetricsForCustomResources object within the QueueMetrics class, the JMX > and Simon QueueMetrics do not report that information for custom resources. -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org