[ 
https://issues.apache.org/jira/browse/YARN-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931077#comment-16931077
 ] 

Daniel Templeton commented on YARN-5913:
----------------------------------------

The issue at hand is that in {{ApplicationSubmissionContext}} {{resource}} 
({{getResource()}}/{{setResource()}}) has the same meaning as 
{{AMContainerResourceRequests}} 
({{getAMContainerResourceRequests()}}/{{setAMContainerResourceRequests()}}).  
Having two different properties that do the same thing is confusing.  The task 
here is to pick one and replace all calls to the other with it.  I would 
recommend replacing all uses of {{resource}} with 
{{AMContainerResourceRequests}}.  Then mark {{getResource()}} and 
{{setResource()}} as deprecated.

There's one more issue.  In YARN-2493 the patch strips the {{@Stable}} tag off 
{{getResource()}} and {{setResource()}}.  That's not OK.  The {{@Stable}} 
should be restored.

Let me know if you need more details.

> Consolidate "resource" and "amResourceRequest" in ApplicationSubmissionContext
> ------------------------------------------------------------------------------
>
>                 Key: YARN-5913
>                 URL: https://issues.apache.org/jira/browse/YARN-5913
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>            Reporter: Yufei Gu
>            Assignee: Yousef Abu-Salah
>            Priority: Minor
>              Labels: newbie
>
> Usage of these two variables overlaps and causes confusion. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to