[ https://issues.apache.org/jira/browse/YARN-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939815#comment-16939815 ]
Íñigo Goiri commented on YARN-9859: ----------------------------------- I think the correct indentation would be: {code} this.oppContainerAllocator = new DistributedOpportunisticContainerAllocator( rmContext.getContainerTokenSecretManager(), maxAllocationsPerAMHeartbeat); {code} Otherwise it is hard to see that they are arguments within the constructor. > Refactor OpportunisticContainerAllocator > ---------------------------------------- > > Key: YARN-9859 > URL: https://issues.apache.org/jira/browse/YARN-9859 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Abhishek Modi > Assignee: Abhishek Modi > Priority: Major > Attachments: YARN-9859.001.patch, YARN-9859.002.patch > > > Right now OpportunisticContainerAllocator is written mainly for Distributed > Scheduling and schedules Opportunistic containers on limited set of nodes. As > part of this jira, we are going to make OpportunisticContainerAllocator as an > abstract class and DistributedOpportunisticContainerAllocator as actual > implementation. This would be prerequisite for YARN-9697. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org