[
https://issues.apache.org/jira/browse/YARN-9768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940184#comment-16940184
]
Íñigo Goiri commented on YARN-9768:
-----------------------------------
[~maniraj...@gmail.com] thank you for the update.
We shouldn't wait a fixed time but use {{GenericTestUtils#waitFor()}} and
ideally wait for some property.
We can wait for the particular assert.
Otherwise, too conservative values lead to long tests and too aggressive values
could introduce flaky tests.
Other minor tests:
* The spacing should be something like: {{"Exhausted max retry attempts {} in
token renewer thread for {}"}}.
* Let's make {{getTokenConf()}} private.
* Can the TimerTask be a lambda?
* Let's avoid TestDelegationTokenRenewer#169.
* It is better to extract the configs values in the test.
* We should not print the stack trace in #1683 but do something more meaningful
or log it properly saying is not an issue.
> RM Renew Delegation token thread should timeout and retry
> ---------------------------------------------------------
>
> Key: YARN-9768
> URL: https://issues.apache.org/jira/browse/YARN-9768
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: CR Hota
> Priority: Major
> Attachments: YARN-9768.001.patch, YARN-9768.002.patch,
> YARN-9768.003.patch
>
>
> Delegation token renewer thread in RM (DelegationTokenRenewer.java) renews
> HDFS tokens received to check for validity and expiration time.
> This call is made to an underlying HDFS NN or Router Node (which has exact
> APIs as HDFS NN). If one of the nodes is bad and the renew call is stuck the
> thread remains stuck indefinitely. The thread should ideally timeout the
> renewToken and retry from the client's perspective.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
