[
https://issues.apache.org/jira/browse/YARN-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944705#comment-16944705
]
Íñigo Goiri commented on YARN-9697:
-----------------------------------
Thanks [~abmodi] for the patch.
Minor comments:
* The javadoc in CentralizedOpportunisticContainerAllocator should say
opportunistic instead of opportunist?
* Should we extract a little CentralizedOpportunisticContainerAllocator#100-101.
* Can we make the loop in CentralizedOpportunisticContainerAllocator#111
cleaner? some breaks, some continue loops, etc. There must be a cleaner way. In
general this class has a lot of this. I would use functions to make this
cleaner.
* Avoid the change in MockNM.
* It would be nice to have comments on
TestCentralizedOpportunisticContainerAllocator#setup, lots of security setup
not clear why.
* Let's do an static import of assertEquals and friends in
TestCentralizedOpportunisticContainerAllocator.
* It looks like a lot of repeated code in
TestCentralizedOpportunisticContainerAllocator. Can we refactor somehow?
> Efficient allocation of Opportunistic containers.
> -------------------------------------------------
>
> Key: YARN-9697
> URL: https://issues.apache.org/jira/browse/YARN-9697
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Abhishek Modi
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-9697.001.patch, YARN-9697.002.patch,
> YARN-9697.003.patch, YARN-9697.ut.patch, YARN-9697.ut2.patch,
> YARN-9697.wip1.patch, YARN-9697.wip2.patch
>
>
> In the current implementation, opportunistic containers are allocated based
> on the number of queued opportunistic container information received in node
> heartbeat. This information becomes stale as soon as more opportunistic
> containers are allocated on that node.
> Allocation of opportunistic containers happens on the same heartbeat in which
> AM asks for the containers. When multiple applications request for
> Opportunistic containers, containers might get allocated on the same set of
> nodes as already allocated containers on the node are not considered while
> serving requests from different applications. This can lead to uneven
> allocation of Opportunistic containers across the cluster leading to
> increased queuing time
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
