[ https://issues.apache.org/jira/browse/YARN-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949389#comment-16949389 ]
Szilard Nemeth commented on YARN-9836: -------------------------------------- Thanks [~adam.antal] for the patch, commited to trunk! Thanks [~shuzirra] for the review! [~adam.antal]: Would you please check if we need these changes in branch-3.2 / branch-3.1 as well? Please especially check if we have the same set of JS dependencies. Thanks! > General usability improvements in showSimulationTrace.html > ---------------------------------------------------------- > > Key: YARN-9836 > URL: https://issues.apache.org/jira/browse/YARN-9836 > Project: Hadoop YARN > Issue Type: Sub-task > Components: scheduler-load-simulator > Affects Versions: 3.3.0 > Reporter: Adam Antal > Assignee: Adam Antal > Priority: Minor > Attachments: YARN-9836.001.patch, YARN-9836.002.patch, > YARN-9836.003.patch > > > There are some small usability improvements that can be made for the offline > analysis page (showSimulationTrace.html): > - empty divs can be hidden until no data is displayed > - the site can be refactored to be responsive given that bootstrap is already > available as third party library > - there's no proper error handling in the site (e.g. a JSON is malformed and > similar cases) which is really a big problem > - there's no indentation in the raw html file which makes supportability even > worse -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org