[ 
https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953124#comment-16953124
 ] 

Eric Badger commented on YARN-9884:
-----------------------------------

Thanks for the review, [~Jim_Brennan]! I've attached patch 004 to slightly 
change the logic around the mount options. Since they are an array of strings, 
I thought it would be better to store them in a {{mount_options}} struct so 
that they would be easier to deal with. The previous patch saved all of the 
options as a string together, which only makes sense in the scope of docker 
arguments. 

> Make container-executor mount logic modular
> -------------------------------------------
>
>                 Key: YARN-9884
>                 URL: https://issues.apache.org/jira/browse/YARN-9884
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>            Priority: Major
>         Attachments: YARN-9884.001.patch, YARN-9884.002.patch, 
> YARN-9884.003.patch, YARN-9884.004.patch
>
>
> The current mount logic in the container-executor is interwined with docker. 
> To avoid duplicating code between docker and runc, the code should be 
> refactored so that both runtimes can use the same common code when possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to