[
https://issues.apache.org/jira/browse/YARN-9966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973798#comment-16973798
]
kevin su commented on YARN-9966:
--------------------------------
[~snemeth] Could you help me review the patch
> Code duplication in UserGroupMappingPlacementRule
> -------------------------------------------------
>
> Key: YARN-9966
> URL: https://issues.apache.org/jira/browse/YARN-9966
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: kevin su
> Priority: Major
> Labels: newbie, newbie++
>
> The methods
> org.apache.hadoop.yarn.server.resourcemanager.placement.UserGroupMappingPlacementRule#validateParentQueue
> and
> org.apache.hadoop.yarn.server.resourcemanager.placement.QueuePlacementRuleUtils#validateQueueMappingUnderParentQueue
> are exactly the same.
> In these 2 classes, we also have a duplicate method named "extractQueuePath".
> We need to extract these to a common method and delete one of these dupes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
