[
https://issues.apache.org/jira/browse/YARN-10000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szilard Nemeth updated YARN-10000:
----------------------------------
Description:
Some things could be improved:
* In initialize: PathFilter can be replaced with lambda
* initialize is long, could be split into smaller methods
* In method 'format': for-loop can be replaced with foreach
* There's a variable with a typo: lastestConfigPath
* Add explanation of unimplemented methods
* Abstract Filesystem operations away more:
* Bad logging: Format string is combined with exception logging.
* LOG.info("Failed to write config version at {}", configVersionFile, e);
* Interestingly phrased log messages like "write temp capacity configuration
fail" "write temp capacity configuration successfully, schedulerConfigFile="
* Method "writeConfigurationToFileSystem" could be private
* Any other code quality improvements
> Code cleanup in FSSchedulerConfigurationStore
> ---------------------------------------------
>
> Key: YARN-10000
> URL: https://issues.apache.org/jira/browse/YARN-10000
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
>
> Some things could be improved:
> * In initialize: PathFilter can be replaced with lambda
> * initialize is long, could be split into smaller methods
> * In method 'format': for-loop can be replaced with foreach
> * There's a variable with a typo: lastestConfigPath
> * Add explanation of unimplemented methods
> * Abstract Filesystem operations away more:
> * Bad logging: Format string is combined with exception logging.
> * LOG.info("Failed to write config version at {}", configVersionFile, e);
> * Interestingly phrased log messages like "write temp capacity configuration
> fail" "write temp capacity configuration successfully, schedulerConfigFile="
> * Method "writeConfigurationToFileSystem" could be private
> * Any other code quality improvements
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
