[ https://issues.apache.org/jira/browse/YARN-10019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995150#comment-16995150 ]
Eric Badger commented on YARN-10019: ------------------------------------ I'm being a skeptic because I don't personally have any experience using _exit. Your logic seems to make sense, so I'm trying to figure it out by asking questions to how it would fail or why it would be unnecessary. In general, this seems like a low-risk change since we don't currently use any on_exit or atexit handlers and the buffers would only provide double logging. However, because of my general lack of experience here, I will yield to Miklos's opinion. > container-executor: misc improvements in child processes and exec() calls > ------------------------------------------------------------------------- > > Key: YARN-10019 > URL: https://issues.apache.org/jira/browse/YARN-10019 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Reporter: Peter Bacsko > Assignee: Peter Bacsko > Priority: Minor > Attachments: YARN-10019-001.patch, YARN-10019-002.patch > > > There are a couple of improvements that we can do in container-executor > regarding how we exit from child processes and how we handle failed exec() > calls: > 1. If we're in the child code path and we detect an erroneous condition, the > usual way is just simply call {{_exit()}}. Normal {{exit()}} occurs in the > parent. Calling {{_exit()}} prevents flushing stdio buffers twice and any > cleanup logic registered with {{atexit()}} or {{on_exit()}} will run only > once. > 2. There's code like {{if (execlp(script_file_dest, script_file_dest, NULL) > != 0) ...}} which is not necessary. Exec functions are not supposed to > return. If they do, it's definitely an error, so no need to check the return > value. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org