[ https://issues.apache.org/jira/browse/YARN-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811377#comment-13811377 ]
Zhijie Shen commented on YARN-1123: ----------------------------------- More minor issues with proto definition. It seems that name convention in proto definition is xxxx_xxxx_xxxx. In addition, it's better to set diagnosticsInfo to "n/a" as default, like other report protos. {code} +message ContainerReportProto { + optional ContainerIdProto containerId = 1; + optional ResourceProto resource = 2; + optional NodeIdProto nodeId = 3; + optional PriorityProto priority = 4; + optional int64 startTime = 5; + optional int64 finishTime = 6; + optional string diagnosticsInfo = 7; + optional string logURL = 8; + optional int32 containerExitStatus = 9; + optional ContainerStateProto containerState = 10; +} {code} > [YARN-321] Adding ContainerReport and Protobuf implementation > ------------------------------------------------------------- > > Key: YARN-1123 > URL: https://issues.apache.org/jira/browse/YARN-1123 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Zhijie Shen > Assignee: Mayank Bansal > Attachments: YARN-1123-1.patch, YARN-1123-2.patch, YARN-1123-3.patch, > YARN-1123-4.patch > > > Like YARN-978, we need some client-oriented class to expose the container > history info. Neither Container nor RMContainer is the right one. -- This message was sent by Atlassian JIRA (v6.1#6144)