[ https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813196#comment-13813196 ]
Mayank Bansal commented on YARN-979: ------------------------------------ [~zjshen] Thanks for the review. bq. You need to change hadoop-yarn-api/pom.xml to make application_history_client.proto to be compiled. Its already there. bq. In addition to the patch's issues, I'd like to raise one design issue here, projecting some future problems. This patch makes different APIs for application/attempt/container, which is going to be a super set of the APIs of ApplicationClientProtocol. Now it's OK if we restrict our problem with the AHS domain. However, probably in the future, we'd like to integrate the ApplicationHistoryProtocol with ApplicationClientProtocol. In other word, from the view of users, they may inquiry any application use a client, which makes it transparent whether the application report is received via ApplicationClientProtocol if the application is running or via ApplicationHistoryProtocol if it is done. Then, ApplicationClientProtocol's and ApplicationHistoryProtocol's APIs mismatch. Users can inquiry finished attempts/containers, but not the running ones. ApplicationClientProtocol may need to add the APIs for attempt/container as well. In addition, another choice of the API design is to still have the only getApplicationReport(), but have the options to load all attempts/containers reports or not. Just think it out aloud. Personally, I incline to the current API design, which is more flexible, but I'm a bit concerned about the future integration. Thoughts? I will create the jira for making applicationclientprotocol similar to applicationHistoryProtocol Thanks, Mayank > [YARN-321] Add more APIs related to ApplicationAttempt and Container in > ApplicationHistoryProtocol > -------------------------------------------------------------------------------------------------- > > Key: YARN-979 > URL: https://issues.apache.org/jira/browse/YARN-979 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Mayank Bansal > Assignee: Mayank Bansal > Attachments: YARN-979-1.patch, YARN-979-3.patch, YARN-979-4.patch, > YARN-979.2.patch > > > ApplicationHistoryProtocol should have the following APIs as well: > * getApplicationAttemptReport > * getApplicationAttempts > * getContainerReport > * getContainers > The corresponding request and response classes need to be added as well. -- This message was sent by Atlassian JIRA (v6.1#6144)