[ 
https://issues.apache.org/jira/browse/YARN-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020522#comment-17020522
 ] 

Wangda Tan commented on YARN-9879:
----------------------------------

[~shuzirra], I think we should not change semantics of GetQueueName of 
AbstractCSQueue to avoid the change of API. (We should keep REST API related to 
queues unchanged otherwise it will be an incompatible change).

Instead of changing GetQueueName, you should check all callers of the 
GetQueueName first. And there's already a GetQueuePath, you can leverage that.

I briefly checked GetQueueName usages, there're 155 of them in production code. 
Most of them are just for logging purposes 
("org.apache.hadoop.yarn.server.resourcemanager.scheduler.activities.*" should 
be considered as logging also). It may take a few hours to identify and change 
everything, but manually change GetQueueName to GetQueuePath case-by-case 
sounds like a safer option to me.

> Allow multiple leaf queues with the same name in CS
> ---------------------------------------------------
>
>                 Key: YARN-9879
>                 URL: https://issues.apache.org/jira/browse/YARN-9879
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Gergely Pollak
>            Assignee: Gergely Pollak
>            Priority: Major
>         Attachments: DesignDoc_v1.pdf, YARN-9879.POC001.patch
>
>
> Currently the leaf queue's name must be unique regardless of its position in 
> the queue hierarchy. 
> Design doc and first proposal is being made, I'll attach it as soon as it's 
> done.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to