[ 
https://issues.apache.org/jira/browse/YARN-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040151#comment-17040151
 ] 

Hudson commented on YARN-10147:
-------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17967 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/17967/])
YARN-10147. FPGA plugin can't find the localized aocx file. Contributed 
(snemeth: rev 3f1aad05f0510d713bdf1297de6cda380c2bb078)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/IntelFpgaOpenclPlugin.java
* (add) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/TestIntelFpgaOpenclPlugin.java


> FPGA plugin can't find the localized aocx file
> ----------------------------------------------
>
>                 Key: YARN-10147
>                 URL: https://issues.apache.org/jira/browse/YARN-10147
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>             Fix For: 3.3.0
>
>         Attachments: YARN-10147-001.patch, YARN-10147-002.patch, 
> YARN-10147-003.patch
>
>
> There's a bug in the FPGA plugin which is intended to find the localized 
> "aocx" file:
> {noformat}
> ...
>     if (localizedResources != null) {
>       Optional<Path> aocxPath = localizedResources
>           .keySet()
>           .stream()
>           .filter(path -> matchesIpid(path, id))
>           .findFirst();
>       if (aocxPath.isPresent()) {
>         ipFilePath = aocxPath.get().toUri().toString();
>         LOG.debug("Found: " + ipFilePath);
>       }
>     } else {
>       LOG.warn("Localized resource is null!");
>     }
>     return ipFilePath;
>   }
>   private boolean matchesIpid(Path p, String id) {
>     return p.getName().toLowerCase().equals(id.toLowerCase())
>         && p.getName().endsWith(".aocx");
>   }
> {noformat}
> The method {{matchesIpid()}} works incorrecty: the {{id}} argument is the 
> expected filename, but without the extension. Therefore the {{equals()}} 
> comparison will always be false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to