[
https://issues.apache.org/jira/browse/YARN-10148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040871#comment-17040871
]
Kinga Marton commented on YARN-10148:
-------------------------------------
Thank you [~adam.antal] for the review. I have addressed your comments in
YARN-10148.003.patch:
- changed the newly introduced queue names to D and D1, where D1 is a child
queue of D. Also added a small comment for {{updateConfigWithDAndD1Queues}}
method
- {{in updateConfigWithDAndD1Queues}} there are mixed the queues from parent
class and the actual one because I just want to update the configuration with
the new queues instead of creating a new one. In this case if I would keep only
the new queues I would have to do a lot of configuration change related the old
ones (stop them, modify the capacities, etc.)
- fixed the indentation (mi idea was set to use 8 spaces for continuation
indent)
- Added assertion message
- reverted TestAbsoluteResourceConfiguration changes: yes, it was by mistake.
This was a good example of why I should not use QUEUE_C again :)
- replaced "test.build.data", in {{TestFairSchedulerQueueACLs with
GenericTestUtils.SYSPROP_TEST_DATA_DIR}}
> Add Unit test for queue ACL for both FS and CS
> ----------------------------------------------
>
> Key: YARN-10148
> URL: https://issues.apache.org/jira/browse/YARN-10148
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
> Reporter: Kinga Marton
> Assignee: Kinga Marton
> Priority: Major
> Attachments: YARN-10148.001.patch, YARN-10148.002.patch,
> YARN-10148.003.patch
>
>
> Add some unit tests covering the queue ACL evaluation for both FS and CS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
