[ 
https://issues.apache.org/jira/browse/YARN-10124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044996#comment-17044996
 ] 

Wilfred Spiegelenburg commented on YARN-10124:
----------------------------------------------

Ah ok, that makes sense now.
Based on the testing you have done it looks like we're all set and do not have 
any side effects of the change.

Two little nits that need to be fixed before we can commit this: can we clean 
up the message generation for the strings and remove the surplus addition in 
the text for the string in these two spots:
{code}
196         throw new IllegalArgumentException("Illegal" + " capacity of "
{code}
and
{code}
229         "Illegal" + " capacity of " + sum + " for children of queue "
{code}

Beside that: +1 

> Remove restriction of ParentQueue capacity zero when childCapacities > 0
> ------------------------------------------------------------------------
>
>                 Key: YARN-10124
>                 URL: https://issues.apache.org/jira/browse/YARN-10124
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler
>    Affects Versions: 3.3.0
>            Reporter: Prabhu Joseph
>            Assignee: Prabhu Joseph
>            Priority: Major
>         Attachments: YARN-10124-001.patch
>
>
> ParentQueue capacity cannot be set to 0 when child capacities > 0. To disable 
> a parent queue temporarily, user can only STOP the queue but the capacity of 
> the queue cannot be used for other queues. Allowing 0 capacity for parent 
> queue will allow user to use the capacity for other queues and also to retain 
> the child queue capacity values. (else user has to set all child queue 
> capacities to 0)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to