[ https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814605#comment-13814605 ]
Vinod Kumar Vavilapalli commented on YARN-987: ---------------------------------------------- Quickly scanned through the patch, comments: - reduce the scope of methods like getLastAttempt, they don't need to be public. - ApplicationHistoryContext -> ApplicationHistoryManager and ApplicationHistory -> ApplicationHistoryManagerImpl. They aren't just context objects. > Adding History Service to use Store and converting Historydata to Report > ------------------------------------------------------------------------ > > Key: YARN-987 > URL: https://issues.apache.org/jira/browse/YARN-987 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Mayank Bansal > Assignee: Mayank Bansal > Attachments: YARN-987-1.patch, YARN-987-2.patch, YARN-987-3.patch, > YARN-987-4.patch, YARN-987-5.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)