[
https://issues.apache.org/jira/browse/YARN-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058334#comment-17058334
]
Wilfred Spiegelenburg commented on YARN-10063:
----------------------------------------------
Can you check this line:
{code}
"%11s launch docker container:%2d appid containerid workdir "
{code}
It removes spacing before the modifier {{%2d}} which is used to line up the
numeric option with the rest of the commands. It don't think that should be
removed.
The rest of the change looks OK.
Waiting for a build to run.
> Usage output of container-executor binary needs to include --http/--https
> argument
> ----------------------------------------------------------------------------------
>
> Key: YARN-10063
> URL: https://issues.apache.org/jira/browse/YARN-10063
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Siddharth Ahuja
> Assignee: Siddharth Ahuja
> Priority: Minor
> Attachments: YARN-10063.001.patch, YARN-10063.002.patch,
> YARN-10063.003.patch
>
>
> YARN-8448/YARN-6586 seems to have introduced a new option - "\--http"
> (default) and "\--https" that is possible to be passed in to the
> container-executor binary, see :
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L564
> and
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L521
> however, the usage output seems to have missed this:
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L74
> Raising this jira to improve this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
