[
https://issues.apache.org/jira/browse/YARN-9999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067591#comment-17067591
]
Szilard Nemeth commented on YARN-9999:
--------------------------------------
Hi [~bteke],
Could you please explain why you removed the following methods from
TestFSSchedulerConfigurationStore?
{code:java}
confirmMutationWithValid,
confirmMutationWithInvalid
{code}
I can see some similar tests in the base class (ConfigurationStoreBaseTest) but
they are seemingly not doing the same.
> TestFSSchedulerConfigurationStore: Extend from ConfigurationStoreBaseTest,
> general code cleanup
> -----------------------------------------------------------------------------------------------
>
> Key: YARN-9999
> URL: https://issues.apache.org/jira/browse/YARN-9999
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Benjamin Teke
> Priority: Minor
> Attachments: YARN-9999.001.patch, YARN-9999.002.patch,
> YARN-9999.003.patch
>
>
> All config store tests are extended from ConfigurationStoreBaseTest:
> * TestInMemoryConfigurationStore
> * TestLeveldbConfigurationStore
> * TestZKConfigurationStore
> TestFSSchedulerConfigurationStore should also extend from it.
> Additionally, some general code cleanup can be applied as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
