[
https://issues.apache.org/jira/browse/YARN-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067624#comment-17067624
]
Hudson commented on YARN-10197:
-------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18093 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/18093/])
YARN-10197. FS-CS converter: fix emitted ordering policy string and (snemeth:
rev 9a297ff31d3e5d16ac648de584d430fc856afefe)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSQueueConverter.java
* (add)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/resources/fair-scheduler-defaultMaxAmShareDisabled.xml
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/resources/fair-scheduler-conversion.xml
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverter.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSConfigToCSConfigConverter.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSQueueConverter.java
> FS-CS converter: fix emitted ordering policy string and max-am-resource
> percent value
> -------------------------------------------------------------------------------------
>
> Key: YARN-10197
> URL: https://issues.apache.org/jira/browse/YARN-10197
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
> Fix For: 3.3.0
>
> Attachments: YARN-10197-001.patch, YARN-10197-002.patch,
> YARN-10197-003.patch
>
>
> There are three problems that have to be addressed in the converter:
> 1) For {{yarn.scheduler.capacity.<path>.ordering-policy}}, the emitted value
> should be "fifo", not "FIFO". The reason we generate "FIFO" is because
> {{FifoPolicy.NAME}} consists of uppercase letters.
> 2) {{maximum-am-resource-percent}} calculation is faulty too. For example, in
> FS, you can globally disable it with
> {{<queueMaxAMShareDefault>-1.0</queueMaxAMShareDefault>}}. However this case
> is not handled properly in
> {{FSConfigToCSConfigConverter.emitDefaultMaxAMShare()}}. -1.0 means that max
> AM check is disabled, therefore we have to generate the value "1.0" to allow
> as many AMs as possible. In {{FSQueueConverter.emitMaxAMShare()}}, we should
> also check if the current value differs from the global setting and only then
> output "1.0" for a given queue.
> 3) The multi-leaf queue check is no longer necessary and it doesn't work
> anyway. The CS instance catches this kind of error during the verification
> step.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
