[ https://issues.apache.org/jira/browse/YARN-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074847#comment-17074847 ]
Jonathan Hung commented on YARN-10212: -------------------------------------- [~BilwaST] user's default max AM attempts is how many AM attempts they get if they don't set individualMaxAppAttempts on client side. I am proposing changing the code snippet above to something like: {noformat} int globalMaxAppAttempts = conf.getInt(YarnConfiguration.GLOBAL_RM_AM_MAX_ATTEMPTS, conf.getInt(YarnConfiguration.RM_AM_MAX_ATTEMPTS, YarnConfiguration.DEFAULT_RM_AM_MAX_ATTEMPTS));{noformat} If GLOBAL_RM_AM_MAX_ATTEMPTS is unset, it will fall back to current behavior. But if GLOBAL_RM_AM_MAX_ATTEMPTS is set to something higher (e.g. 4), then if user does not set individualMaxAppAttempts on client side, their app's number of attempts will still use RM_AM_MAX_ATTEMPTS, but user can set individualMaxAppAttempts to RM_AM_MAX_ATTEMPTS < individualMaxAppAttempts <= GLOBAL_RM_AM_MAX_ATTEMPTS if they like. > Create separate configuration for max global AM attempts > -------------------------------------------------------- > > Key: YARN-10212 > URL: https://issues.apache.org/jira/browse/YARN-10212 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Jonathan Hung > Assignee: Bilwa S T > Priority: Major > > Right now user's default max AM attempts is set to the same as global max AM > attempts: > {noformat} > int globalMaxAppAttempts = conf.getInt(YarnConfiguration.RM_AM_MAX_ATTEMPTS, > YarnConfiguration.DEFAULT_RM_AM_MAX_ATTEMPTS); {noformat} > If we want to increase global max AM attempts, it will also increase the > default. So we should create a separate global AM max attempts config to > separate the two. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org