[
https://issues.apache.org/jira/browse/YARN-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089925#comment-17089925
]
Young Chen commented on YARN-10201:
-----------------------------------
Thanks [~goiri] for the feedback - I fixed the more immediate comments first.
I'll go over the test cases and clean up /add coverage as necessary today.
* Add javadocs to the new methods in AMRMClientRelayer. I would also extract
the values like {{this.remotePendingAsks.get(key)}}.
The extraction was using the container and also relaxing the constraints when
matching. Actually after looking it again, I think it would be okay to just
directly construct the ResourceRequestKey via Container (maybe w/ a new
constructor overload). What do you think about this option?
* Javadoc with example for SubClusterId#getShortId(), it would be good if it
had examples.
getShortId() wasn't actually being used here, so I've removed it. I'll add it
back as part of the patch that depends on it.
* Overall, I think we should go some more tests a little more specific, ideas
that come to mind are the whole protobuf. ContainerAsksBalancer, and the code
path that leads to routeNodeRequestIfNeeded.
Agreed, I'll clean this up in the next patch.
Let me know if I missed anything.
> Make AMRMProxyPolicy aware of SC load
> -------------------------------------
>
> Key: YARN-10201
> URL: https://issues.apache.org/jira/browse/YARN-10201
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: amrmproxy
> Reporter: Young Chen
> Assignee: Young Chen
> Priority: Major
> Attachments: YARN-10201.v0.patch, YARN-10201.v1.patch,
> YARN-10201.v2.patch, YARN-10201.v3.patch, YARN-10201.v4.patch,
> YARN-10201.v5.patch, YARN-10201.v6.patch
>
>
> LocalityMulticastAMRMProxyPolicy is currently unaware of SC load when
> splitting resource requests. We propose changes to the policy so that it
> receives feedback from SCs and can load balance requests across the federated
> cluster.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
