[ https://issues.apache.org/jira/browse/YARN-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095256#comment-17095256 ]
Adam Antal commented on YARN-10160: ----------------------------------- Thanks for the patch [~prabhujoseph]. LGTM overall (non-binding). Minor nit: in {{LeafQueueTemplateInfo.ConfItem}} 's inner fields can be final, as they are only set once - in the constructor. Also: why do you break the imports into multiple lines in {{TestRMWebServicesCapacitySched}}? They don't have to be. > Add auto queue creation related configs to > RMWebService#CapacitySchedulerQueueInfo > ---------------------------------------------------------------------------------- > > Key: YARN-10160 > URL: https://issues.apache.org/jira/browse/YARN-10160 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 3.3.0 > Reporter: Prabhu Joseph > Assignee: Prabhu Joseph > Priority: Major > Attachments: Screen Shot 2020-02-25 at 9.06.52 PM.png, > YARN-10160-001.patch, YARN-10160-002.patch, YARN-10160-003.patch, > YARN-10160-004.patch, YARN-10160-005.patch, YARN-10160-006.patch, > YARN-10160-007.patch, YARN-10160-008.patch > > > Add auto queue creation related configs to > RMWebService#CapacitySchedulerQueueInfo. > {code} > yarn.scheduler.capacity.<queue-path>.auto-create-child-queue.enabled > yarn.scheduler.capacity.<queue-path>.leaf-queue-template.<leaf-queue-property> > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org