[ https://issues.apache.org/jira/browse/YARN-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106252#comment-17106252 ]
Peter Bacsko commented on YARN-10254: ------------------------------------- Thanks for the latest patch [~shuzirra] I don't really complaint other than logging. I do believe that we need to extend the current code and this patch with more logging. My ideas: 1. {{getContextForGroupParent()}} - log if {{groupQueue}} is not found 2. {{getPlacementContextWithParent()}} - log if {{parent}} is null, this should be at least a warning. 3. Under the comment "if the queue doesn't exit we return null" - log if {{queue}} is null 4. {{getPlacementContextNoParent()}} - log if {{queue}} is null 5. I can see extra messages in {{getPlacementForUser}} potentially useful. For example, before each {{return}} statement, we could log stuff like: {noformat} } else if (mapping.getQueue().equals(CURRENT_USER_MAPPING)) { LOG.debug("Creating placement context based on current-user mapping"); return getPlacementContext(mapping, user); } else if (mapping.getQueue().equals(PRIMARY_GROUP_MAPPING)) { LOG.debug("Creating placement context based on primary-group mapping"); return getPlacementContext(mapping, getPrimaryGroup(user)); {noformat} I think it's OK to have them on DEBUG level, with the exception of #2. But to me, even INFO sounds reasonable. This class has been changed substantially in the past months (15 commits since 2019 Oct), I'd feel safer with extra printouts. > CapacityScheduler incorrect User Group Mapping after leaf queue change > ---------------------------------------------------------------------- > > Key: YARN-10254 > URL: https://issues.apache.org/jira/browse/YARN-10254 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Gergely Pollak > Assignee: Gergely Pollak > Priority: Major > Attachments: YARN-10254.001.patch, YARN-10254.002.patch, > YARN-10254.003.patch > > > YARN-9879 and YARN-10198 introduced some major changes to user group mapping, > and some of them unfortunately had some negative impact on the way mapping > works. > In some cases incorrect PlacementContexts were created, where full queue path > was passed as leaf queue name. This affects how the yarn cli app list > displays the queues. > u:%user:%primary_group.%user mapping fails with an incorrect validation error > when the %primary_group parent queue was a managed parent. > Group based rules in certain cases are mapped to root.[primary_group] rules, > loosing the ability to create deeper structures. > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org