[ https://issues.apache.org/jira/browse/YARN-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126764#comment-17126764 ]
Adam Antal commented on YARN-9883: ---------------------------------- Hi [~BilwaST], Sorry for the delay. I totally agree, thanks for sharing the link. Would be happy to review patch if you upload it. > Reshape SchedulerHealth class > ----------------------------- > > Key: YARN-9883 > URL: https://issues.apache.org/jira/browse/YARN-9883 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager, yarn > Affects Versions: 3.3.0 > Reporter: Adam Antal > Assignee: Bilwa S T > Priority: Minor > > The {{SchedulerHealth}} class has some flaws, for example: > - It has no javadoc at all > - All its objects are package-private: they should be private > - The internal maps should be (Concurrent) EnumMaps instead of HashMaps: they > are more efficient in storing Enums > - schedulerHealthDetails only stores the last operation, its name should > reflect that (just like lastSchedulerRunDetails) -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org