[
https://issues.apache.org/jira/browse/YARN-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142799#comment-17142799
]
Prabhu Joseph commented on YARN-8047:
-------------------------------------
[~BilwaST] Thanks for the patch. Below are some of the comments.
1. yarn-default.xml
a. The description of yarn.http.rmwebapp.external.classes says "Used to
specify custom web application pages".
This looks not correct, can we change it to "Used to specify custom web
services for ResourceManager"
2. RMWebApp.java
b. Below code is not necessary as getClasses won't return null.
{code:java}
+ if (externalClasses == null) {
+ return;
+ }
{code}
3. RmController.java
a. Below needs to be removed.
+ System.out.println(schedulerName);
b. This is affecting existing behavior for custom schedulers, we need to
show the DefaultSchedulerPage.class
if hadoop.http.rmwebapp.scheduler.page.class not configured. And a warn
message into log saying
the custom page class is not found if user has configured a class which
does not exist.
+ renderText("Not Found");
4. Can you also include a unit testcase which shows custom webservice and
custom page works fine.
> RMWebApp make external class pluggable
> --------------------------------------
>
> Key: YARN-8047
> URL: https://issues.apache.org/jira/browse/YARN-8047
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Bibin Chundatt
> Assignee: Bilwa S T
> Priority: Minor
> Attachments: YARN-8047-001.patch, YARN-8047-002.patch,
> YARN-8047-003.patch, YARN-8047.004.patch, YARN-8047.005.patch
>
>
> JIra should make sure we should be able to plugin webservices and web pages
> of scheduler in Resourcemanager
> * RMWebApp allow to bind external classes
> * RMController allow to plugin scheduler classes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
