[ 
https://issues.apache.org/jira/browse/YARN-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147865#comment-17147865
 ] 

Szilard Nemeth commented on YARN-10278:
---------------------------------------

Thanks [~epayne]

> CapacityScheduler test framework 
> ProportionalCapacityPreemptionPolicyMockFramework need some review
> ---------------------------------------------------------------------------------------------------
>
>                 Key: YARN-10278
>                 URL: https://issues.apache.org/jira/browse/YARN-10278
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Gergely Pollak
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-10278.001.patch, YARN-10278.002.patch
>
>
> This test framework class mocks a bit too heavily, and simulates CS internal 
> behaviour with the mock methods over a point it is reasonably maintainable, 
> any internal change in CS is a major headscratch.
> A lot of tests depend on this class, so we should approach it carefully, but 
> I think it's wroth to examine this class if it can be made a bit more 
> resilient to changes, and easier to maintain. Or at least document it better.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to