[
https://issues.apache.org/jira/browse/YARN-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169246#comment-17169246
]
Bibin Chundatt commented on YARN-10335:
---------------------------------------
Thank you [~cyrusjackson25] for patch
Just did a brief look at the patch .. Few comments
# Could be assigned to *NodeHealthCheckerService*
{noformat}
107 NodeHealthCheckerServiceImpl healthChecker =
108 createNodeHealthCheckerService();
{noformat}
# Update to readlock for get API
{noformat}
528 public NodeHealthDetails getNodeHealthDetails() {
529 this.writeLock.lock();
530
531 try {
532 return this.nodeHealthDetails;
533 } finally {
534 this.writeLock.unlock();
535 }
536 }
{noformat}
# Fix all jenkins erros..
> Improve scheduling of containers based on node health
> -----------------------------------------------------
>
> Key: YARN-10335
> URL: https://issues.apache.org/jira/browse/YARN-10335
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Bibin Chundatt
> Assignee: Cyrus Jackson
> Priority: Major
> Attachments: YARN-10335.001.patch, YARN-10335.002.patch,
> YARN-10335.003.patch, YARN-10335.004.patch
>
>
> YARN-7494 supports providing interface to choose nodeset for scheduler
> allocation.
> We could leverage the same to support allocation of containers based on node
> health value send from nodemanagers
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
