[ https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822141#comment-13822141 ]
Zhijie Shen commented on YARN-955: ---------------------------------- The patch is almost fine. One more comment. Please add the corresponding configs in yarn-default.xml as well. {code} + /** host:port address for Application History Server API. */ + public static final String AHS_ADDRESS = AHS_PREFIX + "address"; + public static final int DEFAULT_AHS_PORT = 10200; + public static final String DEFAULT_AHS_ADDRESS = "0.0.0.0:" + + DEFAULT_AHS_PORT; + + /** The number of threads to handle client API requests. */ + public static final String AHS_CLIENT_THREAD_COUNT = AHS_PREFIX + + "client.thread-count"; + public static final int DEFAULT_AHS_CLIENT_THREAD_COUNT = 10; {code} > [YARN-321] Implementation of ApplicationHistoryProtocol > ------------------------------------------------------- > > Key: YARN-955 > URL: https://issues.apache.org/jira/browse/YARN-955 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Vinod Kumar Vavilapalli > Assignee: Mayank Bansal > Attachments: YARN-955-1.patch, YARN-955-2.patch, YARN-955-3.patch, > YARN-955-4.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)