[ 
https://issues.apache.org/jira/browse/YARN-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192250#comment-17192250
 ] 

Szilard Nemeth edited comment on YARN-10424 at 9/8/20, 2:41 PM:
----------------------------------------------------------------

[~bteke],

Thanks for working on this, looks good to me.

Can you make sure the checkstyle issues are fixed?

Otherwise, this seems ready to be committed.

[~pbacsko] What do you think? 


was (Author: snemeth):
[~bteke],

Thanks for workin on this, looks good to me.

Can you make sure the checkstyle issues are fixed?

Otherwise, this seems ready to be committed.

[~pbacsko] What do you think? 

> Adapt existing AppName and UserGroupMapping unittests to ensure backwards 
> compatibility
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-10424
>                 URL: https://issues.apache.org/jira/browse/YARN-10424
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Benjamin Teke
>            Assignee: Benjamin Teke
>            Priority: Major
>         Attachments: YARN-10424.001.patch, YARN-10424.002.patch
>
>
> The class {{UserGroupMappingPlacementRule}} and 
> {{AppNameMappingPlacementRule}} will disappear. In order to ensure backwards 
> compatibility when the configuration is defined in the legacy format, 
> {{TestAppNameMappingPlacementRule}} and {{TestUserGroupMappingPlacementRule}} 
> should be adapted to use the new evaluator logic.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to