[ https://issues.apache.org/jira/browse/YARN-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195727#comment-17195727 ]
Jim Brennan commented on YARN-10430: ------------------------------------ Thanks for the patch [~BilwaST]! +1 this looks good to me. > Log improvements in NodeStatusUpdaterImpl > ----------------------------------------- > > Key: YARN-10430 > URL: https://issues.apache.org/jira/browse/YARN-10430 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Bilwa S T > Assignee: Bilwa S T > Priority: Minor > Attachments: YARN-10430.001.patch > > > I think in below places log should be printed only if list size is not zero. > {code:java} > if (LOG.isDebugEnabled()) { > LOG.debug("The cache log aggregation status size:" > + logAggregationReports.size()); > } > {code} > {code:java} > LOG.info("Sending out " + containerStatuses.size() > + " NM container statuses: " + containerStatuses); > {code} > {code:java} > if (LOG.isDebugEnabled()) { > LOG.debug("Sending out " + containerStatuses.size() > + " container statuses: " + containerStatuses); > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org