[
https://issues.apache.org/jira/browse/YARN-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208690#comment-17208690
]
Adam Antal commented on YARN-10420:
-----------------------------------
Thanks for the patch [~pbacsko]. Awesome patch, thanks for the effort on this!
If you don't mind I take the initiative to read through the doc, as I wasn't
much involved in the process and I checked whether I could comprehend it.
Some questions:
- It's a bit strange that the two configuration options in the Queue lifetime
for applications chapter are different:
one is {{yarn.scheduler.capacity.<queue-path>.maximum-application-lifetime}}
and the other is
{{yarn.scheduler.capacity.root.<queue-path>.default-application-lifetime}}.
Is there any specific reason why one is started with root and the other is
not? I think it may be a mistake as in the doc it says "This feature can be set
at any level in the queue hierarchy.".
- Will the rule fails if the create flag is set for a non-managed queue? What
is the expected behaviour? (Maybe we can add some details to the create flag
part)
- Can you use multiple {{setDefaultQueue}} rule? (Maybe we can add some
details to the doc.)
- "In this table, you can see how to rewrite the old, colon-separated rules to
the new format." <-Are these mapping rules FS or CS specific? Can we add that?
Nits:
- You can use the {{```json}} syntax for the block codes to have json syntax
highlight (it is used for xml in this page).
- The Example does not show a rule where the "create" flag is set (either to
true or false). I think we should add one for the sake of completeness.
Other nits with inlined suggestions:
- "The {{CapacityScheduler}} supports the following parameters to _configure_
lifetime of an application"
- "When the evaluation stops and what happens if a rule doesn't match can be
adjusted more flexibly compared to the legacy mapping rule evaluator." -> "It
can be adjusted more flexibly compared to the legacy mapping rule evaluator
what happens when the evaluation stops and a given rule doesn't match."
- "In case of user, primaryGroup, primaryGroupUser, secondaryGroup,
secondaryGroupUser -,- _policies_ this tells the engine where the matching
queue should be looked for."
- "If the target queue doesn't exist -or- _and_ it cannot be created, it
defines a fallback action. Valid values are skip, reject and placeDefault."
- "placeDefault: place the application to the default queue -"- _`_
root.default _`_ -"- (unless it's overridden to something else)." <- Use `
instead of "
- "Places the application into the default queue root.default -but this can be
changed.- _or its overwritten value._"
- "It can be a managed parent in order to have userName leaf created
automatically, -but- _and_ ..." <- "can" should be "shouldn't"?
- "The custom placement policy can describe other policies with the appropriate
variable placeholders _(see below)_ ."
Note:
- The asterisk is not displayed correctly on markdown, but is generated
correctly by {{mvn site}}. I wonder if we can do something about it. I know
that is common to link the markdown from the GH repository instead of using the
generated documentation from the website, so it would be nice if the markdown
could display this correctly.
If you anything is not clear, please let me know and I try to clarify what I
didn't understand.
> Update CS MappingRule documentation with the new format and features
> --------------------------------------------------------------------
>
> Key: YARN-10420
> URL: https://issues.apache.org/jira/browse/YARN-10420
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gergely Pollak
> Assignee: Peter Bacsko
> Priority: Major
> Attachments: YARN-10420-001.patch, YARN-10420-002.patch,
> YARN-10420-003.patch
>
>
> Update the upstream documentation with the new changes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
