[ 
https://issues.apache.org/jira/browse/YARN-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208783#comment-17208783
 ] 

Peter Bacsko edited comment on YARN-10420 at 10/6/20, 2:16 PM:
---------------------------------------------------------------

Some more:

"If the target queue doesn't exist or and it cannot be created..." - you 
propose "and" but that would mean that we always try to create a non-existing 
queue, which is not the case in CS. Under regular parents, queues cannot be 
created dynamically and CS doesn't even try. Therefore "or" is more appropriate 
here.

""It can be a managed parent in order to have userName leaf created 
automatically, but..." - you propose "and" but this does not make sense. The 
point is that regardless of the type of the parent, it has to exist ie. it has 
to be defined statically in {{capacity-scheduler.xml}}.

""can" should be "shouldn't?"" – no, "can" is the proper word here.


was (Author: pbacsko):
Some more:

"If the target queue doesn't exist or and it cannot be created..." - you 
propose "and" but that would mean that we always try to create a non-existing 
queue, which is not the case in CS. Under regular parents, queues cannot be 
created dynamically and CS doesn't even try. Therefore "or" is more appropriate 
here.

""It can be a managed parent in order to have userName leaf created 
automatically, but..." - you propose "and" but this does not make sense. The 
point is that regardless of the type of the parent, it has to exist ie. it has 
to be defined statically in \{{capacity-scheduler.xml}}.

""can" should be "shouldn't?"" -- no, "can" is the proper word here.

 

 

> Update CS MappingRule documentation with the new format and features
> --------------------------------------------------------------------
>
>                 Key: YARN-10420
>                 URL: https://issues.apache.org/jira/browse/YARN-10420
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Gergely Pollak
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-10420-001.patch, YARN-10420-002.patch, 
> YARN-10420-003.patch
>
>
> Update the upstream documentation with the new changes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to