[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232862#comment-17232862
]
Gergely Pollak commented on YARN-7200:
--------------------------------------
[~akshink] It does matter.
1) You break backwards compatibility, since you cannot guarantee no one uses
multiple instances of the same class. Eg 2 CapacitySchedulerMetrics objects.
2) The class is not singleton, there are no indication that only one instance
should exist (based on its name, actually it might make sense to have multiple
instances), and you were able to use multiple instances, until this change.
3) The SLSCapacityScheduler#setConf creates a new instance of this class, so
there might be a code path, which results in multiple instances.
4) You can access the metrics class via
{code:java}
SchedulerWrapper wrapper = (SchedulerWrapper)rm.getResourceScheduler();
SchedulerMetrics metrics = wrapper.getSchedulerMetrics();
{code}
> SLS generates a realtimetrack.json file but that file is missing the closing
> ']'
> --------------------------------------------------------------------------------
>
> Key: YARN-7200
> URL: https://issues.apache.org/jira/browse/YARN-7200
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler-load-simulator
> Reporter: Grant Sohn
> Assignee: Agshin Kazimli
> Priority: Minor
> Labels: newbie, newbie++
> Attachments: YARN-7200-branch-trunk.patch, realtimetrack.json,
> snemeth-testing-20201113.zip
>
>
> File
> hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SchedulerMetrics.java
> shows:
> {noformat}
> void tearDown() throws Exception {
> if (metricsLogBW != null) {
> metricsLogBW.write("]");
> metricsLogBW.close();
> }
> ....
> {noformat}
> So the exit logic is flawed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
