[ 
https://issues.apache.org/jira/browse/YARN-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242803#comment-17242803
 ] 

Hadoop QA commented on YARN-10494:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||  Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
30s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
3s{color} | {color:green}{color} | {color:green} No case conflicting files 
found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green}{color} | {color:green} The patch does not contain any 
@author tags. {color} |
| {color:green}+1{color} | {color:green} {color} | {color:green}  0m  0s{color} 
| {color:green}test4tests{color} | {color:green} The patch appears to include 
68 new or modified test files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m 
41s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
38s{color} | {color:green}{color} | {color:green} trunk passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
37s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private 
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
42s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m 
41s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
20m 11s{color} | {color:green}{color} | {color:green} branch has no errors when 
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
47s{color} | {color:green}{color} | {color:green} trunk passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
26s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private 
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  6m  
3s{color} | {color:blue}{color} | {color:blue} Used deprecated FindBugs config; 
considering switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
59s{color} | {color:green}{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
36s{color} | {color:blue}{color} | {color:blue} Maven dependency ordering for 
patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
56s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
24s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m 
24s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
36s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
36s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 49s{color} | 
{color:orange}https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/354/artifact/out/diff-checkstyle-hadoop-tools.txt{color}
 | {color:orange} hadoop-tools: The patch generated 399 new + 0 unchanged - 0 
fixed = 399 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  3m  
9s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green}{color} | {color:green} The patch has no whitespace 
issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green}{color} | {color:green} The patch has no ill-formed 
XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
16m 37s{color} | {color:green}{color} | {color:green} patch has no errors when 
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
30s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
59s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  6m 
33s{color} | 
{color:red}https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/354/artifact/out/new-findbugs-hadoop-tools.html{color}
 | {color:red} hadoop-tools generated 25 new + 0 unchanged - 0 fixed = 25 total 
(was 0) {color} |
|| || || || {color:brown} Other Tests {color} || ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
32s{color} | {color:green}{color} | {color:green} hadoop-runc in the patch 
passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 56m 15s{color} 
| 
{color:red}https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/354/artifact/out/patch-unit-hadoop-tools.txt{color}
 | {color:red} hadoop-tools in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
32s{color} | 
{color:red}https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/354/artifact/out/patch-asflicense-problems.txt{color}
 | {color:red} The patch generated 6 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}162m 41s{color} | 
{color:black}{color} | {color:black}{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-tools |
|  |  Self assignment of field DockerClient.manifestChooser in 
org.apache.hadoop.runc.docker.DockerClient.setManifestChooser(ManifestChooser)  
At DockerClient.java:in 
org.apache.hadoop.runc.docker.DockerClient.setManifestChooser(ManifestChooser)  
At DockerClient.java:[line 94] |
|  |  Inconsistent synchronization of 
org.apache.hadoop.runc.docker.auth.BearerCredentials.token; locked 66% of time  
Unsynchronized access at BearerCredentials.java:66% of time  Unsynchronized 
access at BearerCredentials.java:[line 65] |
|  |  Class org.apache.hadoop.runc.docker.auth.BearerScheme defines 
non-transient non-serializable instance field client  In 
BearerScheme.java:instance field client  In BearerScheme.java |
|  |  org.apache.hadoop.runc.docker.model.ManifestListV2.CONTENT_TYPE isn't 
final but should be  At ManifestListV2.java:be  At ManifestListV2.java:[line 
14] |
|  |  org.apache.hadoop.runc.docker.model.ManifestV2.CONTENT_TYPE isn't final 
but should be  At ManifestV2.java:be  At ManifestV2.java:[line 14] |
|  |  Boxed value is unboxed and then immediately reboxed in 
org.apache.hadoop.runc.squashfs.SquashFsTree.build()  At SquashFsTree.java:then 
immediately reboxed in org.apache.hadoop.runc.squashfs.SquashFsTree.build()  At 
SquashFsTree.java:[line 140] |
|  |  org.apache.hadoop.runc.squashfs.data.DataBlock.getData() may expose 
internal representation by returning DataBlock.data  At DataBlock.java:by 
returning DataBlock.data  At DataBlock.java:[line 28] |
|  |  new org.apache.hadoop.runc.squashfs.data.DataBlock(byte[], int, int) may 
expose internal representation by storing an externally mutable object into 
DataBlock.data  At DataBlock.java:expose internal representation by storing an 
externally mutable object into DataBlock.data  At DataBlock.java:[line 44] |
|  |  Increment of volatile field 
org.apache.hadoop.runc.squashfs.data.DataBlockCache.cacheHits in 
org.apache.hadoop.runc.squashfs.data.DataBlockCache.get(DataBlockCache$Key)  At 
DataBlockCache.java:in 
org.apache.hadoop.runc.squashfs.data.DataBlockCache.get(DataBlockCache$Key)  At 
DataBlockCache.java:[line 53] |
|  |  Increment of volatile field 
org.apache.hadoop.runc.squashfs.data.DataBlockCache.cacheMisses in 
org.apache.hadoop.runc.squashfs.data.DataBlockCache.get(DataBlockCache$Key)  At 
DataBlockCache.java:in 
org.apache.hadoop.runc.squashfs.data.DataBlockCache.get(DataBlockCache$Key)  At 
DataBlockCache.java:[line 47] |
|  |  org.apache.hadoop.runc.squashfs.directory.DirectoryEntry.getName() may 
expose internal representation by returning DirectoryEntry.name  At 
DirectoryEntry.java:by returning DirectoryEntry.name  At 
DirectoryEntry.java:[line 67] |
|  |  org.apache.hadoop.runc.squashfs.inode.BasicFileINode.getBlockSizes() may 
expose internal representation by returning BasicFileINode.blockSizes  At 
BasicFileINode.java:by returning BasicFileINode.blockSizes  At 
BasicFileINode.java:[line 190] |
|  |  org.apache.hadoop.runc.squashfs.inode.BasicFileINode.setBlockSizes(int[]) 
may expose internal representation by storing an externally mutable object into 
BasicFileINode.blockSizes  At BasicFileINode.java:by storing an externally 
mutable object into BasicFileINode.blockSizes  At BasicFileINode.java:[line 
195] |
|  |  org.apache.hadoop.runc.squashfs.inode.BasicSymlinkINode.getTargetPath() 
may expose internal representation by returning BasicSymlinkINode.targetPath  
At BasicSymlinkINode.java:by returning BasicSymlinkINode.targetPath  At 
BasicSymlinkINode.java:[line 68] |
|  |  org.apache.hadoop.runc.squashfs.inode.ExtendedFileINode.getBlockSizes() 
may expose internal representation by returning ExtendedFileINode.blockSizes  
At ExtendedFileINode.java:by returning ExtendedFileINode.blockSizes  At 
ExtendedFileINode.java:[line 85] |
|  |  
org.apache.hadoop.runc.squashfs.inode.ExtendedFileINode.setBlockSizes(int[]) 
may expose internal representation by storing an externally mutable object into 
ExtendedFileINode.blockSizes  At ExtendedFileINode.java:by storing an 
externally mutable object into ExtendedFileINode.blockSizes  At 
ExtendedFileINode.java:[line 90] |
|  |  
org.apache.hadoop.runc.squashfs.inode.ExtendedSymlinkINode.getTargetPath() may 
expose internal representation by returning ExtendedSymlinkINode.targetPath  At 
ExtendedSymlinkINode.java:by returning ExtendedSymlinkINode.targetPath  At 
ExtendedSymlinkINode.java:[line 53] |
|  |  new 
org.apache.hadoop.runc.squashfs.metadata.MemoryMetadataBlockReader(int, 
SuperBlock, byte[], int, int) may expose internal representation by storing an 
externally mutable object into MemoryMetadataBlockReader.data  At 
MemoryMetadataBlockReader.java:int) may expose internal representation by 
storing an externally mutable object into MemoryMetadataBlockReader.data  At 
MemoryMetadataBlockReader.java:[line 45] |
|  |  org.apache.hadoop.runc.squashfs.metadata.MetadataBlock.getData() may 
expose internal representation by returning MetadataBlock.data  At 
MetadataBlock.java:by returning MetadataBlock.data  At MetadataBlock.java:[line 
63] |
|  |  new org.apache.hadoop.runc.squashfs.table.MemoryTableReader(SuperBlock, 
byte[], int, int) may expose internal representation by storing an externally 
mutable object into MemoryTableReader.data  At MemoryTableReader.java:may 
expose internal representation by storing an externally mutable object into 
MemoryTableReader.data  At MemoryTableReader.java:[line 41] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.runc.squashfs.util.SquashDebug.run(String[])  At 
SquashDebug.java:org.apache.hadoop.runc.squashfs.util.SquashDebug.run(String[]) 
 At SquashDebug.java:[line 195] |
|  |  Boxing/unboxing to parse a primitive 
org.apache.hadoop.runc.squashfs.util.SquashDebug.run(String[])  At 
SquashDebug.java:org.apache.hadoop.runc.squashfs.util.SquashDebug.run(String[]) 
 At SquashDebug.java:[line 194] |
|  |  Possible null pointer dereference in 
org.apache.hadoop.runc.tools.ImportDockerImage.deleteRecursive(File) due to 
return value of called method  Dereferenced at 
ImportDockerImage.java:org.apache.hadoop.runc.tools.ImportDockerImage.deleteRecursive(File)
 due to return value of called method  Dereferenced at 
ImportDockerImage.java:[line 472] |
|  |  Exceptional return value of java.io.File.delete() ignored in 
org.apache.hadoop.runc.tools.ImportDockerImage.deleteRecursive(File)  At 
ImportDockerImage.java:ignored in 
org.apache.hadoop.runc.tools.ImportDockerImage.deleteRecursive(File)  At 
ImportDockerImage.java:[line 476] |
|  |  Exceptional return value of java.io.File.mkdirs() ignored in 
org.apache.hadoop.runc.tools.ImportDockerImage.importDockerImage(String, 
String)  At ImportDockerImage.java:ignored in 
org.apache.hadoop.runc.tools.ImportDockerImage.importDockerImage(String, 
String)  At ImportDockerImage.java:[line 201] |
| Failed junit tests | hadoop.tools.dynamometer.TestDynamometerInfra |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/354/artifact/out/Dockerfile
 |
| JIRA Issue | YARN-10494 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13016380/YARN-10494.001.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite 
unit shadedclient xml findbugs checkstyle |
| uname | Linux d20e4454c99f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 2b5b556dd7f |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
| Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
|  Test Results | 
https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/354/testReport/ |
| Max. process+thread count | 973 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-runc hadoop-tools U: hadoop-tools |
| Console output | 
https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/354/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |


This message was automatically generated.



> CLI tool for docker-to-squashfs conversion (pure Java)
> ------------------------------------------------------
>
>                 Key: YARN-10494
>                 URL: https://issues.apache.org/jira/browse/YARN-10494
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>    Affects Versions: 3.3.0
>            Reporter: Craig Condit
>            Assignee: Craig Condit
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: YARN-10494.001.patch, 
> docker-to-squashfs-conversion-tool-design.pdf
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> *YARN-9564* defines a docker-to-squashfs image conversion tool that relies on 
> python2, multiple libraries, squashfs-tools and root access in order to 
> convert Docker images to squashfs images for use with the runc container 
> runtime in YARN.
> *YARN-9943* was created to investigate alternatives, as the response to 
> merging YARN-9564 has not been very positive. This proposal outlines the 
> design for a CLI conversion tool in 100% pure Java that will work out of the 
> box.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to