[
https://issues.apache.org/jira/browse/YARN-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248744#comment-17248744
]
Bibin Chundatt commented on YARN-10519:
---------------------------------------
Few minor comments
# Change the visibility of queueMetricsForCustomResources to protected in
QueueMetrics and avoid ref in CSQueueMetrics
{code}
225 this.csQueueMetricsForCustomResources =
226 new CSQueueMetricsForCustomResources();
227
setQueueMetricsForCustomResources(csQueueMetricsForCustomResources);
{code}
# Remove new line
{code}
644
677 private void incrementPendingResources(int containers, Resource res)
{ 645 private void incrementPendingResources(int containers,
Resource res) {
{code}
> Refactor QueueMetricsForCustomResources class to move to yarn-common package
> ----------------------------------------------------------------------------
>
> Key: YARN-10519
> URL: https://issues.apache.org/jira/browse/YARN-10519
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Minni Mittal
> Assignee: Minni Mittal
> Priority: Major
> Attachments: YARN-10519.v1.patch, YARN-10519.v2.patch,
> YARN-10519.v3.patch
>
>
> Refactor the code for QueueMetricsForCustomResources to move the base classes
> to yarn-common package. This helps in reusing the class in adding custom
> resource types at NM level also.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
