[
https://issues.apache.org/jira/browse/YARN-4783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252062#comment-17252062
]
Szilard Nemeth commented on YARN-4783:
--------------------------------------
Thanks [~gandras] for working on this.
1. Please fix the javadoc problems. For reference, I saved them for you, as
Jenkins servers keep the results only for a limited time:
{code}
[WARNING]
/home/jenkins/jenkins-home/workspace/PreCommit-YARN-Build/sourcedir/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/security/NMDelegationTokenManager.java:44:
warning: no description for @throws
[WARNING]
/home/jenkins/jenkins-home/workspace/PreCommit-YARN-Build/sourcedir/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/security/NMDelegationTokenManager.java:45:
warning: no description for @throws
[WARNING]
/home/jenkins/jenkins-home/workspace/PreCommit-YARN-Build/sourcedir/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/security/NMDelegationTokenManager.java:58:
warning: no description for @throws
[WARNING]
/home/jenkins/jenkins-home/workspace/PreCommit-YARN-Build/sourcedir/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/security/NMDelegationTokenManager.java:59:
warning: no description for @throws
[WARNING]
/home/jenkins/jenkins-home/workspace/PreCommit-YARN-Build/sourcedir/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/security/NMDelegationTokenManager.java:73:
warning: no description for @throws
[WARNING]
/home/jenkins/jenkins-home/workspace/PreCommit-YARN-Build/sourcedir/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/security/NMDelegationTokenManager.java:87:
warning: no description for @throws
[WARNING]
/home/jenkins/jenkins-home/workspace/PreCommit-YARN-Build/sourcedir/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/security/NMDelegationTokenManager.java:88:
warning: no description for @throws
[WARNING]
/home/jenkins/jenkins-home/workspace/PreCommit-YARN-Build/sourcedir/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/security/NMDelegationTokenManager.java:100:
warning: no description for @throws
[WARNING]
/home/jenkins/jenkins-home/workspace/PreCommit-YARN-Build/sourcedir/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/security/NMDelegationTokenManager.java:101:
warning: no description for @throws
{code}
2. Just asking this to be on the safe side. I can only see one place where the
token is cancelled, which is in the transition method of
AppCompletelyDoneTransition. Is this the only transition you need to take care
of?
3. Please add assertion messages for all asserts in test method:
TestApplication#testAppInitWithManagedDelegationToken
4. Nit: NMDelegationTokenManager#requestNewToken: Last statement can fit into a
single line.
5. Nit:
NMDelegationTokenManager#cancelToken(org.apache.hadoop.security.token.Token<?>,
java.lang.String) can be private.
Apart from these, the latest patch looks good to me.
> Log aggregation failure for application when Nodemanager is restarted
> ----------------------------------------------------------------------
>
> Key: YARN-4783
> URL: https://issues.apache.org/jira/browse/YARN-4783
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.7.1
> Reporter: Surendra Singh Lilhore
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-4783.001.patch, YARN-4783.002.patch,
> YARN-4783.003.patch, YARN-4783.004.patch, YARN-4783.005.patch,
> YARN-4783.005.patch, YARN-4783.006.patch
>
>
> Scenario :
> =========
> 1.Start NM with user dsperf:hadoop
> 2.Configure linux-execute user as dsperf
> 3.Submit application with yarn user
> 4.Once few containers are allocated to NM 1
> 5.Nodemanager 1 is stopped (wait for expiry )
> 6.Start node manager after application is completed
> 7.Check the log aggregation is happening for the containers log in NMLocal
> directory
> Expect Output :
> ===============
> Log aggregation should be succesful
> Actual Output :
> ===============
> Log aggreation not successful
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
