[
https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264048#comment-17264048
]
zhuqi edited comment on YARN-10506 at 1/13/21, 10:33 AM:
---------------------------------------------------------
[~gandras]
Regarding 2.2 atomicity:
The last instanceof Parent check should have never occurred, because then we
have already made every necessary check. I have only included that step because
I was reluctant to use a casting without an explicit check. I find it too, so
just changed to the one class in update.
Copy constructor is a good idea.
about : Regarding CSQueueUtils#extractQueuePath. I think we should keep this
here, because I have seen the same thing repeated over and over across the code
base, so I will instead address this in the cleanup jira.
I think this is the minor things, we my should deal with the major things first.
was (Author: zhuqi):
[~gandras]
Regarding 2.2 atomicity:
The last instanceof Parent check should have never occurred, because then we
have already made every necessary check. I have only included that step because
I was reluctant to use a casting without an explicit check. I find it too, so
just change to the one class.
Copy constructor is a good idea.
about : Regarding CSQueueUtils#extractQueuePath. I think we should keep this
here, because I have seen the same thing repeated over and over across the code
base, so I will instead address this in the cleanup jira.
I think this is the minor things, we my should deal with the major things first.
> Update queue creation logic to use weight mode and allow the flexible
> static/dynamic creation
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-10506
> URL: https://issues.apache.org/jira/browse/YARN-10506
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Benjamin Teke
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-10506-006-10504-010.patch,
> YARN-10506-007-10504-010.patch, YARN-10506-008.patch, YARN-10506-010.patch,
> YARN-10506.001.patch, YARN-10506.002.patch, YARN-10506.003.patch,
> YARN-10506.004.patch, YARN-10506.005.patch, YARN-10506.006-combined.patch,
> YARN-10506.006.patch, YARN-10506.007.patch, YARN-10506.009.patch
>
>
> The queue creation logic should be updated to use weight mode and support the
> flexible creation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
