[ 
https://issues.apache.org/jira/browse/YARN-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266356#comment-17266356
 ] 

Szilard Nemeth commented on YARN-10490:
---------------------------------------

Hi [~akshink],
Thanks for working on this.

I'm a bit confused.
Looking at the source code of TopCLI, there's a method named "clearScreen": 
https://github.com/apache/hadoop/blob/630f8ddd2c72c27b02032ed3cf9dde15745ed605/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/TopCLI.java#L473

It's implementation prints the CLEAR string from this class to the System.out 
stream.
You introduced a string called CLEAR_SCREEN.
So the namings are quite confusing.
Did you test to call the clearScreen method from the shutdown hook?
If not, please test it and you don't need the new constant.

Thanks.

> "yarn top" command not quitting completely with ctrl+c
> ------------------------------------------------------
>
>                 Key: YARN-10490
>                 URL: https://issues.apache.org/jira/browse/YARN-10490
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: yarn
>            Reporter: Agshin Kazimli
>            Assignee: Agshin Kazimli
>            Priority: Minor
>         Attachments: YARN-10490-001.patch, YARN-10490-001.patch, 
> YARN-10490-002.patch
>
>
> When we quit "yarn top" command using ctrl+c, even though the command prompt 
> returns, the old statistics info is still visible below the prompt.
> And we need to manually type clear command or multiple return keys to get 
> around it. It is reported as a inconvenience for the customer from a 
> usability perspective.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to