[
https://issues.apache.org/jira/browse/YARN-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267869#comment-17267869
]
Gergely Pollak commented on YARN-10578:
---------------------------------------
[~gandras] thank you for the patch, my only observation is you are using a lock
before calling the _autoQueueHandler.autoCreateQueue(placementContext_);
however if this operation requires a lock, it would be better to have that
lock in the _autoCreateQueue_ method, to make sure no other code path can
concurrently modify it. (Even if we don't call it elsewhere currently).
Otherwise LGTM+1 (Non-binding)
> Fix Auto Queue Creation parent handling
> ---------------------------------------
>
> Key: YARN-10578
> URL: https://issues.apache.org/jira/browse/YARN-10578
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Andras Gyori
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-10578.001.patch, YARN-10578.002.patch
>
>
> YARN-10506 introduced the new auto queue creation logic, however a parent ==
> null check in CapacityScheduler#autoCreateLeafQueue will prevent a two levels
> queue to be created. We need to revert it back to the normal logic, also, we
> should wrap the auto queue handling with a lock.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
